Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.1: storage: remove WAL failover enterprise license check #131543

Merged
merged 1 commit into from
Sep 29, 2024
Merged

release-24.1: storage: remove WAL failover enterprise license check #131543

merged 1 commit into from
Sep 29, 2024

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Sep 27, 2024 •
edited
Loading

24.1 backport of #131357.

The license check may be performed before the node has fully initialized and knows whether a valid enterprise license is available. A warning may be logged erroneously, which may confuse. Remove the license check altogether given the direction CockroachDB enterprise licensing is moving in general.

Epic: none
Informs #129240.
Release note: none
Release justification: Fixes deceiving error message.

@jbowens
storage: remove WAL failover enterprise license check
c8f4966 
The license check may be performed before the node has fully initialized and
knows whether a valid enterprise license is available. A warning may be logged
erroneously, which may confuse. Remove the license check altogether given the
direction CockroachDB enterprise licensing is moving in general.

Epic: none
Informs cockroachdb#129240.
Release note: none
@jbowens jbowens added the backport Label PR's that are backports to older release branches label Sep 27, 2024
@jbowens jbowens requested a review from a team as a code owner September 27, 2024 20:46
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Sep 27, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens jbowens merged commit 8880dd6 into cockroachdb:release-24.1 Sep 29, 2024
19 of 20 checks passed
@jbowens jbowens deleted the 24.1-1599165 branch September 29, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicktrav nicktrav nicktrav approved these changes

@itsbilal itsbilal Awaiting requested review from itsbilal itsbilal is a code owner automatically assigned from cockroachdb/storage

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbowens @cockroach-teamcity @nicktrav